fix: move sync state check from server into test_miner #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephGoulden
force-pushed
the
pause-test-miner
branch
from
9cc288c to
24c2b82
Compare
|
Related - #2964 |
|
Thanks for review and for flagging the related issue.. just had to change an import to grin_chain. |
|
We just merged 2.x.x back onto master (and changed base branch of this PR back to master). Edit: Tested locally in "user testing" with a couple of mining nodes and everything looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to remove a TODO by pushing sync state into test miner.